Skip to content

Extend isTupleLikeType to also check if .length is a number literal type #52617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2023
Merged

Extend isTupleLikeType to also check if .length is a number literal type #52617

merged 3 commits into from
Jun 30, 2023
+92 −4

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Feb 5, 2023

fixes #29311

implements the suggested solution by @ahejlsberg from here

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 5, 2023
@Andarist
Copy link
Contributor Author

Andarist commented Feb 5, 2023

@jakebailey I wonder if this doesn't also resolve what you were trying to solve here, would you mind taking a look?

@jakebailey
Copy link
Member

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 2822e99. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 2822e99. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 2822e99. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 5, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/145606/artifacts?artifactName=tgz&fileId=B494CE6D57673DABE859E313DCB45E88600C4105512E547CB337F310238339D002&fileName=/typescript-5.0.0-insiders.20230205.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52617/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52617/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52617
Metric main 52617 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,815k (± 0.01%) 359,864k (± 0.00%) ~ 359,850k 359,892k p=0.065 n=6
Parse Time 3.97s (± 0.99%) 3.98s (± 0.43%) ~ 3.95s 4.00s p=0.746 n=6
Bind Time 1.17s (± 0.47%) 1.18s (± 0.54%) ~ 1.17s 1.19s p=0.201 n=6
Check Time 8.67s (± 0.42%) 8.71s (± 0.49%) ~ 8.67s 8.78s p=0.108 n=6
Emit Time 7.61s (± 0.50%) 7.63s (± 0.84%) ~ 7.57s 7.72s p=0.871 n=6
Total Time 21.43s (± 0.16%) 21.50s (± 0.46%) ~ 21.40s 21.65s p=0.227 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,107k (± 1.19%) 193,195k (± 1.24%) ~ 192,000k 198,094k p=0.230 n=6
Parse Time 1.64s (± 2.04%) 1.67s (± 2.72%) ~ 1.59s 1.73s p=0.145 n=6
Bind Time 0.80s (± 0.79%) 0.80s (± 0.64%) ~ 0.80s 0.81s p=0.386 n=6
Check Time 9.74s (± 0.63%) 9.79s (± 0.75%) ~ 9.66s 9.88s p=0.229 n=6
Emit Time 2.79s (± 1.27%) 2.85s (± 4.70%) ~ 2.73s 3.11s p=0.568 n=6
Total Time 14.96s (± 0.37%) 15.11s (± 0.94%) +0.14s (+ 0.96%) 15.01s 15.39s p=0.020 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,999k (± 0.01%) 344,042k (± 0.01%) ~ 343,983k 344,092k p=0.336 n=6
Parse Time 2.96s (± 0.39%) 2.95s (± 1.34%) ~ 2.89s 3.01s p=0.514 n=6
Bind Time 1.04s (± 0.61%) 1.04s (± 0.52%) ~ 1.04s 1.05s p=0.201 n=6
Check Time 7.07s (± 0.41%) 7.18s (± 0.56%) +0.11s (+ 1.60%) 7.13s 7.25s p=0.005 n=6
Emit Time 4.34s (± 0.69%) 4.32s (± 0.56%) ~ 4.30s 4.36s p=0.251 n=6
Total Time 15.41s (± 0.27%) 15.50s (± 0.23%) +0.09s (+ 0.61%) 15.47s 15.56s p=0.016 n=6
TFS - node (v18.10.0, x64)
Memory used 300,388k (± 0.01%) 300,407k (± 0.01%) ~ 300,380k 300,426k p=0.378 n=6
Parse Time 2.25s (± 0.99%) 2.29s (± 1.33%) +0.04s (+ 1.93%) 2.25s 2.32s p=0.035 n=6
Bind Time 1.17s (± 0.94%) 1.18s (± 0.69%) ~ 1.17s 1.19s p=0.383 n=6
Check Time 6.53s (± 0.73%) 6.55s (± 0.43%) ~ 6.51s 6.59s p=0.468 n=6
Emit Time 3.92s (± 0.44%) 3.93s (± 0.78%) ~ 3.89s 3.96s p=0.468 n=6
Total Time 13.87s (± 0.32%) 13.95s (± 0.43%) +0.08s (+ 0.58%) 13.85s 14.00s p=0.043 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,877k (± 0.01%) 476,885k (± 0.02%) ~ 476,801k 477,026k p=0.936 n=6
Parse Time 3.57s (± 1.09%) 3.57s (± 0.48%) ~ 3.54s 3.59s p=0.935 n=6
Bind Time 0.97s (± 0.92%) 0.97s (± 0.53%) ~ 0.97s 0.98s p=0.541 n=6
Check Time 17.21s (± 0.62%) 17.32s (± 0.55%) ~ 17.22s 17.46s p=0.077 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.75s (± 0.65%) 21.86s (± 0.45%) ~ 21.77s 22.01s p=0.077 n=6
xstate - node (v18.10.0, x64)
Memory used 549,034k (± 0.02%) 548,947k (± 0.01%) ~ 548,863k 549,032k p=0.128 n=6
Parse Time 4.58s (± 0.36%) 4.58s (± 0.42%) ~ 4.54s 4.59s p=1.000 n=6
Bind Time 1.72s (± 0.68%) 1.72s (± 1.04%) ~ 1.69s 1.74s p=1.000 n=6
Check Time 2.83s (± 0.73%) 2.82s (± 0.80%) ~ 2.78s 2.84s p=0.569 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 9.22s (± 0.43%) 9.20s (± 0.30%) ~ 9.16s 9.24s p=0.686 n=6
Angular - node (v16.17.1, x64)
Memory used 359,228k (± 0.00%) 359,215k (± 0.00%) ~ 359,199k 359,235k p=0.199 n=6
Parse Time 4.19s (± 0.49%) 4.19s (± 0.38%) ~ 4.18s 4.22s p=0.360 n=6
Bind Time 1.23s (± 0.42%) 1.23s (± 0.33%) ~ 1.22s 1.23s p=0.595 n=6
Check Time 9.46s (± 0.42%) 9.45s (± 0.41%) ~ 9.40s 9.51s p=0.747 n=6
Emit Time 8.09s (± 0.28%) 8.08s (± 0.84%) ~ 7.99s 8.19s p=0.618 n=6
Total Time 22.97s (± 0.14%) 22.95s (± 0.40%) ~ 22.83s 23.11s p=0.148 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,973k (± 0.03%) 194,053k (± 0.02%) +80k (+ 0.04%) 193,995k 194,088k p=0.020 n=6
Parse Time 1.81s (± 0.23%) 1.80s (± 0.29%) ~ 1.80s 1.81s p=0.112 n=6
Bind Time 0.85s (± 0.48%) 0.85s (± 1.23%) ~ 0.84s 0.87s p=0.209 n=6
Check Time 10.47s (± 1.19%) 10.53s (± 0.61%) ~ 10.41s 10.59s p=0.469 n=6
Emit Time 3.07s (± 1.04%) 3.06s (± 0.54%) ~ 3.03s 3.07s p=0.416 n=6
Total Time 16.20s (± 0.88%) 16.25s (± 0.35%) ~ 16.14s 16.30s p=0.470 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,253k (± 0.01%) 343,308k (± 0.01%) +55k (+ 0.02%) 343,289k 343,335k p=0.005 n=6
Parse Time 3.15s (± 0.97%) 3.13s (± 0.80%) ~ 3.11s 3.18s p=0.333 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.80%) ~ 1.10s 1.12s p=0.787 n=6
Check Time 7.74s (± 0.32%) 7.86s (± 0.82%) +0.12s (+ 1.51%) 7.79s 7.94s p=0.005 n=6
Emit Time 4.53s (± 0.54%) 4.51s (± 0.54%) ~ 4.49s 4.55s p=0.331 n=6
Total Time 16.53s (± 0.25%) 16.61s (± 0.55%) +0.09s (+ 0.52%) 16.50s 16.75s p=0.036 n=6
TFS - node (v16.17.1, x64)
Memory used 299,779k (± 0.00%) 299,788k (± 0.00%) ~ 299,776k 299,806k p=0.092 n=6
Parse Time 2.48s (± 1.00%) 2.48s (± 1.49%) ~ 2.43s 2.51s p=0.743 n=6
Bind Time 1.26s (± 0.41%) 1.26s (± 0.41%) ~ 1.25s 1.26s p=1.000 n=6
Check Time 7.20s (± 0.37%) 7.24s (± 0.54%) ~ 7.19s 7.31s p=0.056 n=6
Emit Time 4.22s (± 0.77%) 4.23s (± 0.35%) ~ 4.22s 4.25s p=0.682 n=6
Total Time 15.15s (± 0.40%) 15.21s (± 0.46%) ~ 15.14s 15.33s p=0.199 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,124k (± 0.00%) 476,210k (± 0.00%) +86k (+ 0.02%) 476,178k 476,241k p=0.005 n=6
Parse Time 3.71s (± 0.33%) 3.72s (± 0.24%) ~ 3.71s 3.73s p=0.244 n=6
Bind Time 1.02s (± 0.40%) 1.02s (± 0.40%) ~ 1.02s 1.03s p=1.000 n=6
Check Time 18.14s (± 0.48%) 18.32s (± 0.70%) +0.18s (+ 0.97%) 18.16s 18.49s p=0.045 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.88s (± 0.44%) 23.06s (± 0.52%) +0.18s (+ 0.80%) 22.92s 23.22s p=0.020 n=6
xstate - node (v16.17.1, x64)
Memory used 546,714k (± 0.02%) 546,717k (± 0.02%) ~ 546,618k 546,882k p=0.936 n=6
Parse Time 4.77s (± 0.25%) 4.77s (± 0.19%) ~ 4.76s 4.78s p=0.680 n=6
Bind Time 1.84s (± 0.49%) 1.84s (± 0.44%) ~ 1.84s 1.86s p=0.548 n=6
Check Time 3.05s (± 0.84%) 3.06s (± 0.83%) ~ 3.03s 3.10s p=0.808 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 4.45%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 9.76s (± 0.33%) 9.76s (± 0.30%) ~ 9.72s 9.81s p=0.935 n=6
Angular - node (v14.15.1, x64)
Memory used 352,833k (± 0.00%) 352,875k (± 0.01%) +42k (+ 0.01%) 352,849k 352,911k p=0.008 n=6
Parse Time 4.24s (± 0.13%) 4.24s (± 0.64%) ~ 4.20s 4.28s p=0.361 n=6
Bind Time 1.28s (± 0.59%) 1.29s (± 0.32%) ~ 1.28s 1.29s p=0.100 n=6
Check Time 9.74s (± 0.32%) 9.86s (± 0.40%) +0.12s (+ 1.23%) 9.78s 9.89s p=0.005 n=6
Emit Time 8.40s (± 0.88%) 8.45s (± 1.17%) ~ 8.32s 8.58s p=0.296 n=6
Total Time 23.65s (± 0.34%) 23.84s (± 0.44%) +0.19s (+ 0.80%) 23.70s 23.96s p=0.020 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,895k (± 0.07%) 188,903k (± 0.06%) ~ 188,829k 189,136k p=0.298 n=6
Parse Time 1.84s (± 0.49%) 1.86s (± 0.56%) +0.02s (+ 0.91%) 1.84s 1.87s p=0.027 n=6
Bind Time 0.87s (± 0.63%) 0.86s (± 0.60%) ~ 0.86s 0.87s p=0.640 n=6
Check Time 10.50s (± 0.78%) 10.58s (± 0.66%) ~ 10.49s 10.70s p=0.092 n=6
Emit Time 3.38s (± 4.37%) 3.43s (± 4.43%) ~ 3.14s 3.54s p=0.418 n=6
Total Time 16.58s (± 0.78%) 16.73s (± 1.26%) ~ 16.34s 16.95s p=0.128 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,039k (± 0.00%) 338,031k (± 0.00%) ~ 338,003k 338,042k p=0.748 n=6
Parse Time 3.23s (± 0.73%) 3.23s (± 1.15%) ~ 3.17s 3.27s p=0.747 n=6
Bind Time 1.11s (± 0.68%) 1.12s (± 0.67%) ~ 1.11s 1.13s p=0.195 n=6
Check Time 8.12s (± 0.63%) 8.21s (± 0.51%) +0.08s (+ 1.05%) 8.16s 8.27s p=0.031 n=6
Emit Time 4.77s (± 0.44%) 4.77s (± 0.95%) ~ 4.71s 4.85s p=0.935 n=6
Total Time 17.23s (± 0.27%) 17.33s (± 0.47%) ~ 17.22s 17.42s p=0.054 n=6
TFS - node (v14.15.1, x64)
Memory used 294,587k (± 0.01%) 294,580k (± 0.01%) ~ 294,561k 294,610k p=0.575 n=6
Parse Time 2.75s (± 0.48%) 2.76s (± 0.98%) ~ 2.73s 2.81s p=1.000 n=6
Bind Time 1.10s (± 0.74%) 1.09s (± 0.50%) ~ 1.09s 1.10s p=0.859 n=6
Check Time 7.50s (± 0.63%) 7.51s (± 0.35%) ~ 7.47s 7.55s p=0.517 n=6
Emit Time 4.63s (± 0.93%) 4.66s (± 0.78%) ~ 4.59s 4.69s p=0.376 n=6
Total Time 15.98s (± 0.29%) 16.02s (± 0.28%) ~ 15.94s 16.07s p=0.170 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,677k (± 0.00%) 471,641k (± 0.00%) -37k (- 0.01%) 471,619k 471,656k p=0.006 n=6
Parse Time 3.94s (± 0.94%) 3.92s (± 0.57%) ~ 3.90s 3.95s p=0.870 n=6
Bind Time 1.04s (± 0.52%) 1.05s (± 1.20%) ~ 1.03s 1.06s p=0.357 n=6
Check Time 19.10s (± 0.33%) 19.28s (± 0.83%) ~ 19.09s 19.48s p=0.054 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 24.08s (± 0.32%) 24.26s (± 0.67%) ~ 24.06s 24.43s p=0.092 n=6
xstate - node (v14.15.1, x64)
Memory used 534,841k (± 0.01%) 534,878k (± 0.01%) ~ 534,810k 534,932k p=0.199 n=6
Parse Time 5.14s (± 0.85%) 5.18s (± 0.80%) ~ 5.11s 5.22s p=0.091 n=6
Bind Time 1.73s (± 0.85%) 1.73s (± 1.02%) ~ 1.70s 1.75s p=0.744 n=6
Check Time 3.13s (± 0.66%) 3.15s (± 1.21%) ~ 3.10s 3.22s p=0.288 n=6
Emit Time 0.10s (± 4.01%) 0.10s (± 0.00%) ~ 0.10s 0.10s p=0.405 n=6
Total Time 10.10s (± 0.42%) 10.17s (± 0.84%) ~ 10.04s 10.28s p=0.199 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

TSServer

Comparison Report - main..52617
Metric main 52617 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,521ms (± 1.16%) 2,522ms (± 1.45%) ~ 2,486ms 2,580ms p=1.000 n=6
Req 2 - geterr 5,534ms (± 0.83%) 5,590ms (± 0.66%) ~ 5,535ms 5,632ms p=0.093 n=6
Req 3 - references 377ms (± 2.21%) 379ms (± 0.64%) ~ 375ms 381ms p=0.571 n=6
Req 4 - navto 283ms (± 0.52%) 284ms (± 0.43%) ~ 283ms 286ms p=0.138 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 66ms (± 1.87%) 66ms (± 2.31%) ~ 63ms 67ms p=1.000 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,715ms (± 0.64%) 2,727ms (± 0.80%) ~ 2,699ms 2,755ms p=0.378 n=6
Req 2 - geterr 4,059ms (± 0.45%) 4,057ms (± 0.66%) ~ 4,021ms 4,089ms p=0.688 n=6
Req 3 - references 372ms (± 1.17%) 369ms (± 0.40%) ~ 367ms 371ms p=0.255 n=6
Req 4 - navto 298ms (± 1.03%) 298ms (± 0.87%) ~ 294ms 301ms p=0.871 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 81ms (± 5.29%) 82ms (± 6.46%) ~ 71ms 85ms p=0.118 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,502ms (± 0.34%) 3,510ms (± 0.40%) ~ 3,486ms 3,528ms p=0.422 n=6
Req 2 - geterr 1,641ms (± 0.81%) 1,654ms (± 0.97%) ~ 1,630ms 1,677ms p=0.261 n=6
Req 3 - references 104ms (± 1.57%) 104ms (± 0.49%) ~ 104ms 105ms p=0.325 n=6
Req 4 - navto 356ms (± 0.50%) 360ms (± 0.72%) +4ms (+ 1.03%) 356ms 364ms p=0.019 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 475ms (± 1.12%) 473ms (± 0.74%) ~ 469ms 479ms p=0.375 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,776ms (± 0.89%) 2,788ms (± 0.43%) ~ 2,775ms 2,804ms p=0.630 n=6
Req 2 - geterr 5,923ms (± 0.27%) 5,931ms (± 0.61%) ~ 5,880ms 5,977ms p=0.689 n=6
Req 3 - references 381ms (± 0.49%) 379ms (± 0.61%) ~ 377ms 383ms p=0.142 n=6
Req 4 - navto 283ms (± 2.20%) 279ms (± 1.13%) ~ 277ms 285ms p=0.357 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 71ms (± 1.26%) 71ms (± 1.54%) ~ 69ms 72ms p=0.932 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,942ms (± 0.72%) 2,965ms (± 0.93%) ~ 2,944ms 3,013ms p=0.093 n=6
Req 2 - geterr 4,415ms (± 0.30%) 4,427ms (± 0.27%) ~ 4,415ms 4,448ms p=0.149 n=6
Req 3 - references 382ms (± 0.94%) 381ms (± 0.79%) ~ 377ms 385ms p=0.506 n=6
Req 4 - navto 287ms (± 0.44%) 289ms (± 0.36%) ~ 287ms 290ms p=0.071 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 72ms (± 1.17%) 74ms (± 3.05%) +2ms (+ 3.03%) 72ms 78ms p=0.026 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,628ms (± 0.45%) 3,645ms (± 0.64%) ~ 3,611ms 3,679ms p=0.149 n=6
Req 2 - geterr 1,814ms (± 1.65%) 1,814ms (± 1.40%) ~ 1,792ms 1,855ms p=1.000 n=6
Req 3 - references 113ms (± 0.91%) 111ms (± 1.49%) -3ms (- 2.50%) 108ms 113ms p=0.011 n=6
Req 4 - navto 342ms (± 0.77%) 343ms (± 1.24%) ~ 340ms 351ms p=1.000 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 479ms (± 0.68%) 482ms (± 0.90%) ~ 474ms 486ms p=0.199 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,914ms (± 0.53%) 2,912ms (± 0.52%) ~ 2,890ms 2,928ms p=0.936 n=6
Req 2 - geterr 6,354ms (± 1.25%) 6,380ms (± 0.79%) ~ 6,286ms 6,431ms p=0.810 n=6
Req 3 - references 392ms (± 0.39%) 393ms (± 1.47%) ~ 388ms 404ms p=1.000 n=6
Req 4 - navto 284ms (± 1.35%) 285ms (± 1.53%) ~ 278ms 290ms p=0.413 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 85ms (±10.93%) 85ms (±10.08%) ~ 74ms 97ms p=1.000 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,087ms (± 0.79%) 3,097ms (± 0.34%) ~ 3,086ms 3,112ms p=0.423 n=6
Req 2 - geterr 4,717ms (± 0.38%) 4,726ms (± 0.32%) ~ 4,706ms 4,746ms p=0.378 n=6
Req 3 - references 409ms (± 1.15%) 412ms (± 1.20%) ~ 406ms 418ms p=0.252 n=6
Req 4 - navto 296ms (± 0.39%) 297ms (± 0.59%) ~ 295ms 300ms p=0.251 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 83ms (± 4.52%) 86ms (± 5.00%) ~ 80ms 89ms p=0.555 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,990ms (± 0.51%) 3,987ms (± 0.58%) ~ 3,943ms 4,012ms p=1.000 n=6
Req 2 - geterr 1,799ms (± 1.93%) 1,826ms (± 1.70%) ~ 1,785ms 1,862ms p=0.230 n=6
Req 3 - references 131ms (± 3.33%) 128ms (± 2.86%) ~ 122ms 131ms p=0.192 n=6
Req 4 - navto 374ms (± 0.81%) 378ms (± 0.28%) ~ 376ms 379ms p=0.053 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 499ms (± 1.45%) 499ms (± 1.55%) ~ 486ms 507ms p=0.688 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

Startup

Comparison Report - main..52617
Metric main 52617 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.90ms (± 0.19%) 144.11ms (± 0.46%) +1.21ms (+ 0.85%) 142.20ms 147.65ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 227.88ms (± 0.20%) 228.43ms (± 0.25%) +0.55ms (+ 0.24%) 226.81ms 234.73ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 229.86ms (± 0.26%) 230.17ms (± 0.29%) +0.31ms (+ 0.14%) 228.48ms 236.86ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 210.74ms (± 0.29%) 210.57ms (± 0.23%) ~ 209.26ms 214.87ms p=0.059 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52617/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52617/merge:

Something interesting changed - please have a look.

Details

palantir/blueprint

⚠️ Note that built also had errors ⚠️ 
Req #19416 - references
    at getJSDocParameterTagsWorker (/typescript-main/built/local/tsserver.js:13864:37)
    at getJSDocParameterTags (/typescript-main/built/local/tsserver.js:13881:10)
    at getJSDocType (/typescript-main/built/local/tsserver.js:14012:16)
    at getEffectiveTypeAnnotationNode (/typescript-main/built/local/tsserver.js:18570:91)
    at /typescript-main/built/local/tsserver.js:20901:39
    at some (/typescript-main/built/local/tsserver.js:2724:13)
    at hasContextSensitiveParameters (/typescript-main/built/local/tsserver.js:20901:9)
    at isContextSensitiveFunctionLikeDeclaration (/typescript-main/built/local/tsserver.js:62190:12)
    at isContextSensitiveFunctionOrObjectLiteralMethod (/typescript-main/built/local/tsserver.js:62196:90)
    at getNarrowedTypeOfSymbol (/typescript-main/built/local/tsserver.js:69539:44)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69632:16)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68243:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68582:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68468:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68425:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69674:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77735:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77689:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72167:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72246:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77769:16)

Req #19416 - references
    at getContextualTypeForArgument (/typescript-52617/built/local/tsserver.js:70345:40)
    at getContextualType2 (/typescript-52617/built/local/tsserver.js:70789:16)
    at getApparentTypeOfContextualType (/typescript-52617/built/local/tsserver.js:70725:120)
    at getContextualType2 (/typescript-52617/built/local/tsserver.js:70804:22)
    at getApparentTypeOfContextualType (/typescript-52617/built/local/tsserver.js:70725:120)
    at getContextualSignature (/typescript-52617/built/local/tsserver.js:71092:18)
    at getNarrowedTypeOfSymbol (/typescript-52617/built/local/tsserver.js:69541:39)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69633:16)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)
    at getTypeAtFlowCall (/typescript-52617/built/local/tsserver.js:68583:25)
    at getTypeAtFlowNode (/typescript-52617/built/local/tsserver.js:68469:18)
    at getFlowTypeOfReference (/typescript-52617/built/local/tsserver.js:68426:45)
    at checkIdentifier (/typescript-52617/built/local/tsserver.js:69675:22)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77736:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at checkPropertyAccessExpression (/typescript-52617/built/local/tsserver.js:72247:162)
    at checkExpressionWorker (/typescript-52617/built/local/tsserver.js:77770:16)
    at checkExpression (/typescript-52617/built/local/tsserver.js:77690:32)
    at checkNonNullExpression (/typescript-52617/built/local/tsserver.js:72168:29)
    at getEffectsSignature (/typescript-52617/built/local/tsserver.js:68244:22)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

 
{"seq":19413,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":241602}}
{"seq":19414,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":241737,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":"\""}}
{"seq":19415,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":242302}}
{"seq":19416,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":243887}}

Repro Steps
  1. git clone https://github.com/palantir/blueprint --recurse-submodules
  2. In dir blueprint, run git reset --hard 1bbbbab39a274f1e65841e852f9be8bf88d6956e
  3. In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
  4. Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

jakebailey
jakebailey reviewed Feb 5, 2023
View reviewed changes
@jakebailey jakebailey mentioned this pull request Feb 5, 2023
Closed
@sandersn sandersn requested a review from navya9singh March 3, 2023 00:03
@jakebailey
Copy link
Member

Paranoia check

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 2822e99. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52617/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52617/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52617

Metric main 52617 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 361,682k (± 0.01%) 361,698k (± 0.01%) ~ 361,646k 361,731k p=0.471 n=6
Parse Time 3.50s (± 0.76%) 3.52s (± 0.82%) ~ 3.48s 3.56s p=0.171 n=6
Bind Time 1.17s (± 0.44%) 1.18s (± 0.88%) ~ 1.17s 1.20s p=0.051 n=6
Check Time 9.49s (± 0.32%) 9.52s (± 0.42%) ~ 9.48s 9.59s p=0.256 n=6
Emit Time 7.96s (± 0.77%) 7.93s (± 0.23%) ~ 7.91s 7.96s p=0.870 n=6
Total Time 22.13s (± 0.37%) 22.15s (± 0.27%) ~ 22.08s 22.25s p=0.521 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,522k (± 0.03%) 193,690k (± 0.92%) ~ 192,452k 196,072k p=0.128 n=6
Parse Time 1.59s (± 0.95%) 1.59s (± 0.79%) ~ 1.57s 1.61s p=0.677 n=6
Bind Time 0.82s (± 0.77%) 0.82s (± 0.77%) ~ 0.81s 0.83s p=1.000 n=6
Check Time 10.33s (± 0.46%) 10.29s (± 0.70%) ~ 10.20s 10.40s p=0.197 n=6
Emit Time 2.99s (± 0.63%) 2.98s (± 0.56%) ~ 2.96s 3.00s p=0.684 n=6
Total Time 15.73s (± 0.31%) 15.68s (± 0.50%) ~ 15.55s 15.78s p=0.376 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,734k (± 0.01%) 345,780k (± 0.00%) +45k (+ 0.01%) 345,762k 345,790k p=0.005 n=6
Parse Time 2.71s (± 0.43%) 2.73s (± 0.60%) ~ 2.70s 2.74s p=0.166 n=6
Bind Time 1.09s (± 1.87%) 1.08s (± 0.70%) ~ 1.07s 1.09s p=1.000 n=6
Check Time 7.77s (± 0.46%) 7.91s (± 0.51%) +0.14s (+ 1.78%) 7.84s 7.95s p=0.005 n=6
Emit Time 4.44s (± 0.46%) 4.46s (± 0.76%) ~ 4.42s 4.49s p=0.459 n=6
Total Time 16.02s (± 0.30%) 16.18s (± 0.43%) +0.16s (+ 0.99%) 16.09s 16.26s p=0.010 n=6
TFS - node (v16.17.1, x64)
Memory used 300,022k (± 0.00%) 300,024k (± 0.01%) ~ 299,991k 300,056k p=0.936 n=6
Parse Time 2.15s (± 0.38%) 2.16s (± 0.70%) ~ 2.15s 2.18s p=0.357 n=6
Bind Time 1.23s (± 0.84%) 1.24s (± 0.68%) ~ 1.22s 1.24s p=0.923 n=6
Check Time 7.19s (± 0.49%) 7.20s (± 0.17%) ~ 7.18s 7.21s p=0.868 n=6
Emit Time 4.34s (± 0.88%) 4.32s (± 0.70%) ~ 4.28s 4.37s p=0.517 n=6
Total Time 14.92s (± 0.52%) 14.92s (± 0.18%) ~ 14.88s 14.96s p=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,466k (± 0.01%) 476,515k (± 0.01%) +49k (+ 0.01%) 476,486k 476,554k p=0.031 n=6
Parse Time 3.21s (± 0.48%) 3.22s (± 0.28%) ~ 3.21s 3.23s p=0.270 n=6
Bind Time 0.95s (± 0.00%) 0.95s (± 0.54%) ~ 0.95s 0.96s p=0.174 n=6
Check Time 18.12s (± 0.33%) 18.17s (± 0.19%) ~ 18.13s 18.23s p=0.123 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.28s (± 0.26%) 22.34s (± 0.18%) ~ 22.29s 22.41s p=0.064 n=6
xstate - node (v16.17.1, x64)
Memory used 550,514k (± 0.00%) 550,752k (± 0.05%) ~ 550,432k 551,065k p=0.378 n=6
Parse Time 3.93s (± 0.31%) 3.94s (± 0.31%) ~ 3.93s 3.96s p=0.075 n=6
Bind Time 1.75s (± 0.94%) 1.75s (± 0.67%) ~ 1.74s 1.77s p=0.681 n=6
Check Time 3.07s (± 0.57%) 3.07s (± 0.48%) ~ 3.05s 3.09s p=0.803 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.84s (± 0.24%) 8.85s (± 0.29%) ~ 8.83s 8.89s p=0.560 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member

I'm guessing that perf result is a lie caused by the main baseline being behind. Will rerun later.

@jakebailey
Copy link
Member

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52617

Metric main 52617 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 361,718k (± 0.01%) 361,687k (± 0.01%) ~ 361,653k 361,721k p=0.093 n=6
Parse Time 3.53s (± 0.81%) 3.52s (± 0.78%) ~ 3.48s 3.55s p=0.567 n=6
Bind Time 1.18s (± 0.99%) 1.18s (± 0.69%) ~ 1.17s 1.19s p=0.498 n=6
Check Time 9.51s (± 0.22%) 9.48s (± 0.36%) ~ 9.44s 9.52s p=0.123 n=6
Emit Time 7.96s (± 0.76%) 7.95s (± 0.55%) ~ 7.91s 8.03s p=1.000 n=6
Total Time 22.18s (± 0.37%) 22.13s (± 0.29%) ~ 22.04s 22.22s p=0.470 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,581k (± 0.88%) 193,130k (± 0.67%) ~ 192,558k 195,770k p=0.298 n=6
Parse Time 1.58s (± 1.09%) 1.60s (± 0.65%) ~ 1.58s 1.61s p=0.114 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.63%) ~ 0.82s 0.83s p=0.595 n=6
Check Time 10.30s (± 0.43%) 10.32s (± 0.53%) ~ 10.25s 10.39s p=0.470 n=6
Emit Time 2.99s (± 0.61%) 3.02s (± 1.00%) ~ 2.96s 3.05s p=0.073 n=6
Total Time 15.70s (± 0.35%) 15.75s (± 0.49%) ~ 15.64s 15.85s p=0.199 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,729k (± 0.01%) 345,776k (± 0.00%) +47k (+ 0.01%) 345,762k 345,791k p=0.005 n=6
Parse Time 2.72s (± 0.43%) 2.71s (± 0.28%) ~ 2.70s 2.72s p=0.150 n=6
Bind Time 1.08s (± 0.95%) 1.08s (± 0.75%) ~ 1.07s 1.09s p=0.932 n=6
Check Time 7.80s (± 0.44%) 7.92s (± 0.36%) +0.12s (+ 1.56%) 7.89s 7.96s p=0.005 n=6
Emit Time 4.45s (± 0.39%) 4.46s (± 1.09%) ~ 4.41s 4.53s p=1.000 n=6
Total Time 16.06s (± 0.32%) 16.17s (± 0.38%) +0.11s (+ 0.71%) 16.09s 16.26s p=0.010 n=6
TFS - node (v16.17.1, x64)
Memory used 300,020k (± 0.01%) 300,028k (± 0.01%) ~ 300,002k 300,058k p=0.575 n=6
Parse Time 2.16s (± 0.62%) 2.16s (± 0.68%) ~ 2.14s 2.18s p=0.681 n=6
Bind Time 1.24s (± 0.83%) 1.24s (± 1.14%) ~ 1.22s 1.26s p=0.738 n=6
Check Time 7.22s (± 0.73%) 7.17s (± 0.43%) ~ 7.11s 7.20s p=0.063 n=6
Emit Time 4.37s (± 1.05%) 4.33s (± 0.45%) -0.05s (- 1.07%) 4.30s 4.36s p=0.033 n=6
Total Time 14.99s (± 0.63%) 14.90s (± 0.24%) ~ 14.84s 14.94s p=0.126 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,458k (± 0.01%) 476,515k (± 0.01%) +58k (+ 0.01%) 476,465k 476,584k p=0.020 n=6
Parse Time 3.22s (± 0.38%) 3.21s (± 1.01%) ~ 3.15s 3.25s p=0.317 n=6
Bind Time 0.95s (± 0.54%) 0.96s (± 1.67%) ~ 0.95s 0.99s p=0.923 n=6
Check Time 18.21s (± 0.37%) 18.22s (± 0.31%) ~ 18.16s 18.30s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.39s (± 0.28%) 22.38s (± 0.30%) ~ 22.32s 22.46s p=0.936 n=6
xstate - node (v16.17.1, x64)
Memory used 550,607k (± 0.02%) 550,620k (± 0.03%) ~ 550,496k 550,933k p=0.689 n=6
Parse Time 3.93s (± 0.49%) 3.92s (± 0.30%) ~ 3.91s 3.94s p=0.357 n=6
Bind Time 1.76s (± 0.43%) 1.76s (± 0.56%) ~ 1.75s 1.77s p=1.000 n=6
Check Time 3.09s (± 1.02%) 3.07s (± 0.61%) ~ 3.05s 3.10s p=0.468 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.87s (± 0.60%) 8.83s (± 0.16%) ~ 8.82s 8.86s p=0.194 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 2822e99. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52617
Metric main 52617 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 362,358k (± 0.01%) 362,351k (± 0.01%) ~ 362,290k 362,399k p=1.000 n=6
Parse Time 3.36s (± 0.35%) 3.38s (± 0.41%) ~ 3.36s 3.40s p=0.054 n=6
Bind Time 1.11s (± 1.09%) 1.12s (± 0.46%) ~ 1.11s 1.12s p=0.666 n=6
Check Time 8.72s (± 0.59%) 8.70s (± 0.45%) ~ 8.68s 8.78s p=0.366 n=6
Emit Time 7.50s (± 0.76%) 7.49s (± 0.68%) ~ 7.40s 7.55s p=0.470 n=6
Total Time 20.70s (± 0.41%) 20.68s (± 0.34%) ~ 20.56s 20.78s p=0.630 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,745k (± 1.19%) 190,873k (± 0.03%) ~ 190,784k 190,955k p=0.378 n=6
Parse Time 1.49s (± 0.35%) 1.48s (± 1.81%) ~ 1.43s 1.51s p=0.794 n=6
Bind Time 0.77s (± 0.72%) 0.77s (± 0.98%) ~ 0.76s 0.78s p=0.476 n=6
Check Time 9.57s (± 0.70%) 9.66s (± 0.76%) +0.09s (+ 0.98%) 9.62s 9.81s p=0.007 n=6
Emit Time 2.74s (± 0.64%) 2.74s (± 0.55%) ~ 2.73s 2.77s p=1.000 n=6
Total Time 14.56s (± 0.47%) 14.65s (± 0.36%) +0.09s (+ 0.61%) 14.62s 14.76s p=0.006 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,439k (± 0.01%) 346,474k (± 0.01%) ~ 346,444k 346,499k p=0.377 n=6
Parse Time 2.57s (± 0.84%) 2.56s (± 0.52%) ~ 2.54s 2.58s p=0.405 n=6
Bind Time 1.00s (± 0.00%) 1.01s (± 0.81%) ~ 1.00s 1.02s p=0.073 n=6
Check Time 7.08s (± 0.39%) 7.22s (± 0.25%) +0.14s (+ 1.93%) 7.20s 7.25s p=0.005 n=6
Emit Time 4.23s (± 0.55%) 4.22s (± 0.77%) ~ 4.19s 4.28s p=0.744 n=6
Total Time 14.88s (± 0.30%) 15.01s (± 0.19%) +0.12s (+ 0.83%) 14.98s 15.06s p=0.005 n=6
TFS - node (v18.10.0, x64)
Memory used 300,663k (± 0.00%) 300,679k (± 0.01%) ~ 300,659k 300,695k p=0.078 n=6
Parse Time 2.06s (± 0.91%) 2.04s (± 1.44%) ~ 2.00s 2.09s p=0.568 n=6
Bind Time 1.14s (± 0.45%) 1.14s (± 0.45%) ~ 1.14s 1.15s p=0.069 n=6
Check Time 6.55s (± 0.34%) 6.54s (± 0.44%) ~ 6.50s 6.58s p=0.566 n=6
Emit Time 3.85s (± 1.12%) 3.83s (± 0.27%) ~ 3.82s 3.85s p=0.684 n=6
Total Time 13.59s (± 0.34%) 13.56s (± 0.21%) ~ 13.52s 13.59s p=0.296 n=6
material-ui - node (v18.10.0, x64)
Memory used 477,162k (± 0.01%) 477,171k (± 0.01%) ~ 477,095k 477,228k p=0.689 n=6
Parse Time 3.00s (± 2.64%) 3.02s (± 2.45%) ~ 2.93s 3.11s p=0.520 n=6
Bind Time 0.97s (± 7.62%) 0.96s (± 7.67%) ~ 0.90s 1.07s p=0.808 n=6
Check Time 17.19s (± 0.88%) 17.14s (± 0.42%) ~ 17.04s 17.22s p=0.470 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.16s (± 0.78%) 21.11s (± 0.41%) ~ 20.98s 21.18s p=0.809 n=6
xstate - node (v18.10.0, x64)
Memory used 553,132k (± 0.02%) 553,002k (± 0.03%) ~ 552,816k 553,266k p=0.173 n=6
Parse Time 3.77s (± 0.80%) 3.77s (± 0.50%) ~ 3.75s 3.80s p=0.746 n=6
Bind Time 1.67s (± 0.31%) 1.66s (± 0.91%) ~ 1.63s 1.67s p=0.143 n=6
Check Time 2.85s (± 0.43%) 2.84s (± 0.68%) ~ 2.81s 2.86s p=0.871 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.36s (± 0.32%) 8.35s (± 0.41%) ~ 8.29s 8.39s p=0.572 n=6
Angular - node (v16.17.1, x64)
Memory used 361,701k (± 0.01%) 361,709k (± 0.01%) ~ 361,656k 361,740k p=0.810 n=6
Parse Time 3.54s (± 0.81%) 3.53s (± 0.78%) ~ 3.49s 3.56s p=0.808 n=6
Bind Time 1.18s (± 0.64%) 1.17s (± 0.64%) ~ 1.16s 1.18s p=0.062 n=6
Check Time 9.53s (± 0.68%) 9.48s (± 0.71%) ~ 9.43s 9.61s p=0.225 n=6
Emit Time 7.98s (± 0.69%) 7.94s (± 0.49%) ~ 7.87s 7.98s p=0.295 n=6
Total Time 22.22s (± 0.22%) 22.12s (± 0.25%) -0.11s (- 0.48%) 22.08s 22.23s p=0.020 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,125k (± 0.73%) 192,624k (± 0.03%) ~ 192,567k 192,684k p=0.471 n=6
Parse Time 1.58s (± 0.86%) 1.60s (± 0.51%) ~ 1.58s 1.60s p=0.058 n=6
Bind Time 0.82s (± 0.92%) 0.82s (± 0.77%) ~ 0.81s 0.83s p=0.718 n=6
Check Time 10.26s (± 0.39%) 10.33s (± 0.81%) ~ 10.23s 10.46s p=0.091 n=6
Emit Time 3.01s (± 0.56%) 3.01s (± 0.46%) ~ 2.98s 3.02s p=0.932 n=6
Total Time 15.67s (± 0.27%) 15.76s (± 0.58%) ~ 15.66s 15.90s p=0.108 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,726k (± 0.01%) 345,771k (± 0.01%) +45k (+ 0.01%) 345,752k 345,801k p=0.045 n=6
Parse Time 2.71s (± 0.50%) 2.71s (± 0.49%) ~ 2.69s 2.73s p=0.452 n=6
Bind Time 1.08s (± 0.48%) 1.08s (± 0.48%) ~ 1.08s 1.09s p=1.000 n=6
Check Time 7.78s (± 0.36%) 7.93s (± 0.40%) +0.15s (+ 1.95%) 7.89s 7.97s p=0.005 n=6
Emit Time 4.47s (± 0.79%) 4.45s (± 0.72%) ~ 4.42s 4.50s p=0.293 n=6
Total Time 16.04s (± 0.24%) 16.18s (± 0.27%) +0.14s (+ 0.84%) 16.12s 16.25s p=0.005 n=6
TFS - node (v16.17.1, x64)
Memory used 300,030k (± 0.01%) 300,019k (± 0.00%) ~ 300,005k 300,036k p=0.423 n=6
Parse Time 2.16s (± 0.56%) 2.15s (± 0.54%) ~ 2.13s 2.16s p=0.323 n=6
Bind Time 1.24s (± 0.68%) 1.23s (± 0.80%) ~ 1.22s 1.24s p=0.256 n=6
Check Time 7.19s (± 0.36%) 7.20s (± 0.45%) ~ 7.17s 7.24s p=0.808 n=6
Emit Time 4.34s (± 0.50%) 4.34s (± 1.12%) ~ 4.26s 4.40s p=0.936 n=6
Total Time 14.92s (± 0.26%) 14.92s (± 0.41%) ~ 14.84s 14.99s p=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,469k (± 0.01%) 476,502k (± 0.01%) ~ 476,461k 476,541k p=0.173 n=6
Parse Time 3.21s (± 0.41%) 3.22s (± 0.26%) ~ 3.21s 3.23s p=0.788 n=6
Bind Time 0.95s (± 0.00%) 0.95s (± 0.00%) ~ 0.95s 0.95s p=1.000 n=6
Check Time 18.17s (± 0.50%) 18.13s (± 0.64%) ~ 18.00s 18.34s p=0.521 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.33s (± 0.46%) 22.30s (± 0.54%) ~ 22.17s 22.52s p=0.521 n=6
xstate - node (v16.17.1, x64)
Memory used 550,548k (± 0.01%) 550,503k (± 0.01%) ~ 550,420k 550,570k p=0.378 n=6
Parse Time 3.93s (± 0.47%) 3.92s (± 0.16%) ~ 3.91s 3.93s p=0.288 n=6
Bind Time 1.76s (± 1.08%) 1.75s (± 0.69%) ~ 1.74s 1.77s p=0.566 n=6
Check Time 3.08s (± 0.56%) 3.09s (± 0.48%) ~ 3.07s 3.11s p=0.294 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.86s (± 0.31%) 8.85s (± 0.35%) ~ 8.81s 8.88s p=0.871 n=6
Angular - node (v14.15.1, x64)
Memory used 355,558k (± 0.01%) 355,578k (± 0.00%) ~ 355,564k 355,601k p=0.066 n=6
Parse Time 3.63s (± 0.79%) 3.60s (± 0.46%) ~ 3.58s 3.62s p=0.061 n=6
Bind Time 1.22s (± 0.52%) 1.22s (± 0.69%) ~ 1.21s 1.23s p=0.226 n=6
Check Time 9.86s (± 0.39%) 9.91s (± 0.47%) ~ 9.85s 9.97s p=0.107 n=6
Emit Time 8.36s (± 0.93%) 8.41s (± 0.54%) ~ 8.32s 8.45s p=0.420 n=6
Total Time 23.07s (± 0.50%) 23.13s (± 0.32%) ~ 23.00s 23.22s p=0.230 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,795k (± 0.01%) 187,884k (± 0.01%) +88k (+ 0.05%) 187,862k 187,931k p=0.005 n=6
Parse Time 1.59s (± 0.86%) 1.60s (± 0.73%) ~ 1.59s 1.62s p=0.170 n=6
Bind Time 0.85s (± 0.00%) 0.85s (± 0.00%) ~ 0.85s 0.85s p=1.000 n=6
Check Time 10.48s (± 0.27%) 10.50s (± 0.28%) ~ 10.46s 10.53s p=0.192 n=6
Emit Time 3.14s (± 0.90%) 3.14s (± 0.77%) ~ 3.10s 3.17s p=0.686 n=6
Total Time 16.06s (± 0.29%) 16.08s (± 0.17%) ~ 16.04s 16.11s p=0.332 n=6
Monaco - node (v14.15.1, x64)
Memory used 340,598k (± 0.01%) 340,622k (± 0.01%) ~ 340,595k 340,653k p=0.199 n=6
Parse Time 2.83s (± 0.61%) 2.83s (± 1.02%) ~ 2.80s 2.88s p=0.366 n=6
Bind Time 1.11s (± 0.76%) 1.10s (± 0.74%) ~ 1.09s 1.11s p=0.718 n=6
Check Time 8.15s (± 0.12%) 8.27s (± 0.51%) +0.12s (+ 1.43%) 8.22s 8.34s p=0.005 n=6
Emit Time 4.69s (± 0.57%) 4.69s (± 0.25%) ~ 4.68s 4.71s p=0.934 n=6
Total Time 16.77s (± 0.25%) 16.89s (± 0.38%) +0.11s (+ 0.69%) 16.83s 16.98s p=0.005 n=6
TFS - node (v14.15.1, x64)
Memory used 295,097k (± 0.00%) 295,090k (± 0.00%) ~ 295,068k 295,102k p=0.518 n=6
Parse Time 2.40s (± 0.98%) 2.38s (± 0.72%) ~ 2.36s 2.40s p=0.254 n=6
Bind Time 1.07s (± 0.51%) 1.06s (± 0.49%) ~ 1.06s 1.07s p=0.640 n=6
Check Time 7.53s (± 0.58%) 7.54s (± 0.37%) ~ 7.50s 7.58s p=0.746 n=6
Emit Time 4.30s (± 0.87%) 4.30s (± 0.82%) ~ 4.25s 4.34s p=1.000 n=6
Total Time 15.29s (± 0.41%) 15.28s (± 0.26%) ~ 15.24s 15.34s p=0.747 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,990k (± 0.01%) 471,999k (± 0.00%) ~ 471,964k 472,021k p=0.575 n=6
Parse Time 3.37s (± 0.41%) 3.35s (± 0.53%) ~ 3.32s 3.37s p=0.067 n=6
Bind Time 1.00s (± 0.52%) 0.99s (± 0.55%) ~ 0.99s 1.00s p=0.640 n=6
Check Time 19.16s (± 0.81%) 19.22s (± 0.55%) ~ 19.09s 19.39s p=0.471 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.52s (± 0.71%) 23.56s (± 0.48%) ~ 23.43s 23.74s p=0.630 n=6
xstate - node (v14.15.1, x64)
Memory used 539,191k (± 0.00%) 539,201k (± 0.00%) ~ 539,172k 539,229k p=0.748 n=6
Parse Time 4.22s (± 0.61%) 4.25s (± 0.71%) ~ 4.20s 4.28s p=0.168 n=6
Bind Time 1.66s (± 0.59%) 1.66s (± 0.38%) ~ 1.65s 1.67s p=1.000 n=6
Check Time 3.19s (± 0.87%) 3.20s (± 0.72%) ~ 3.17s 3.23s p=0.687 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.17s (± 0.50%) 9.20s (± 0.59%) ~ 9.11s 9.25s p=0.199 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

TSServer

Comparison Report - main..52617
Metric main 52617 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,394ms (± 0.56%) 2,387ms (± 0.48%) ~ 2,369ms 2,405ms p=0.630 n=6
Req 2 - geterr 5,573ms (± 0.73%) 5,532ms (± 0.30%) -41ms (- 0.74%) 5,505ms 5,549ms p=0.045 n=6
Req 3 - references 336ms (± 0.61%) 336ms (± 0.39%) ~ 335ms 338ms p=1.000 n=6
Req 4 - navto 282ms (± 0.43%) 280ms (± 0.18%) ~ 280ms 281ms p=0.051 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 1.75%) 84ms (± 0.97%) ~ 83ms 85ms p=0.666 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,521ms (± 1.11%) 2,511ms (± 1.31%) ~ 2,451ms 2,539ms p=0.748 n=6
Req 2 - geterr 4,069ms (± 0.92%) 4,078ms (± 0.63%) ~ 4,037ms 4,106ms p=0.688 n=6
Req 3 - references 348ms (± 1.41%) 349ms (± 1.03%) ~ 345ms 354ms p=0.629 n=6
Req 4 - navto 290ms (± 0.86%) 290ms (± 0.84%) ~ 287ms 293ms p=0.808 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 79ms (± 4.90%) 79ms (± 5.98%) ~ 70ms 84ms p=0.933 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,005ms (± 0.64%) 3,004ms (± 0.75%) ~ 2,985ms 3,035ms p=1.000 n=6
Req 2 - geterr 1,687ms (± 0.99%) 1,681ms (± 1.52%) ~ 1,653ms 1,723ms p=0.575 n=6
Req 3 - references 107ms (± 0.38%) 107ms (± 0.51%) ~ 106ms 107ms p=0.282 n=6
Req 4 - navto 356ms (± 0.63%) 357ms (± 0.41%) ~ 355ms 358ms p=0.256 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 376ms (± 2.80%) 376ms (± 1.77%) ~ 369ms 386ms p=1.000 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,510ms (± 0.34%) 2,496ms (± 0.87%) ~ 2,474ms 2,530ms p=0.229 n=6
Req 2 - geterr 5,917ms (± 0.79%) 5,921ms (± 0.54%) ~ 5,868ms 5,959ms p=1.000 n=6
Req 3 - references 344ms (± 0.35%) 345ms (± 0.44%) ~ 343ms 346ms p=0.677 n=6
Req 4 - navto 279ms (± 0.45%) 277ms (± 0.54%) ~ 276ms 280ms p=0.084 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 74ms (± 1.40%) 74ms (± 1.02%) ~ 73ms 75ms p=0.931 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,648ms (± 0.52%) 2,674ms (± 0.59%) +26ms (+ 0.97%) 2,657ms 2,693ms p=0.037 n=6
Req 2 - geterr 4,449ms (± 0.41%) 4,416ms (± 0.66%) -32ms (- 0.73%) 4,381ms 4,468ms p=0.045 n=6
Req 3 - references 365ms (± 0.17%) 363ms (± 0.48%) ~ 362ms 366ms p=0.131 n=6
Req 4 - navto 287ms (± 0.78%) 286ms (± 0.42%) ~ 285ms 288ms p=1.000 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 1.56%) 77ms (± 3.02%) ~ 75ms 80ms p=0.935 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,141ms (± 0.16%) 3,144ms (± 0.25%) ~ 3,131ms 3,155ms p=0.520 n=6
Req 2 - geterr 1,860ms (± 1.39%) 1,847ms (± 1.12%) ~ 1,827ms 1,875ms p=0.423 n=6
Req 3 - references 114ms (± 1.79%) 114ms (± 0.92%) ~ 112ms 115ms p=0.864 n=6
Req 4 - navto 341ms (± 0.52%) 342ms (± 0.73%) ~ 339ms 345ms p=0.936 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 391ms (± 0.88%) 395ms (± 1.57%) ~ 385ms 403ms p=0.227 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,592ms (± 0.80%) 2,607ms (± 0.33%) ~ 2,599ms 2,620ms p=0.173 n=6
Req 2 - geterr 6,328ms (± 0.55%) 6,344ms (± 0.32%) ~ 6,320ms 6,373ms p=0.298 n=6
Req 3 - references 364ms (± 0.76%) 363ms (± 0.82%) ~ 359ms 366ms p=0.466 n=6
Req 4 - navto 282ms (± 1.05%) 280ms (± 0.58%) ~ 278ms 282ms p=0.466 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 95ms (± 8.58%) 96ms (± 9.15%) ~ 81ms 104ms p=0.571 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,811ms (± 0.39%) 2,817ms (± 0.48%) ~ 2,801ms 2,842ms p=0.810 n=6
Req 2 - geterr 4,798ms (± 0.43%) 4,785ms (± 0.64%) ~ 4,753ms 4,838ms p=0.298 n=6
Req 3 - references 370ms (± 0.71%) 371ms (± 0.77%) ~ 368ms 376ms p=0.466 n=6
Req 4 - navto 295ms (± 1.56%) 291ms (± 1.78%) ~ 287ms 298ms p=0.464 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 74ms (± 0.00%) 74ms (± 0.85%) ~ 73ms 75ms p=1.000 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,448ms (± 0.39%) 3,450ms (± 0.45%) ~ 3,431ms 3,470ms p=0.936 n=6
Req 2 - geterr 1,885ms (± 0.96%) 1,883ms (± 1.38%) ~ 1,836ms 1,909ms p=1.000 n=6
Req 3 - references 124ms (± 0.83%) 124ms (± 0.72%) ~ 123ms 125ms p=0.673 n=6
Req 4 - navto 371ms (± 0.53%) 373ms (± 0.80%) ~ 369ms 377ms p=0.141 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 409ms (± 0.96%) 411ms (± 0.61%) ~ 408ms 414ms p=0.418 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

Startup

Comparison Report - main..52617
Metric main 52617 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.36ms (± 0.18%) 141.41ms (± 0.18%) +0.05ms (+ 0.03%) 140.77ms 146.45ms p=0.003 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.32ms (± 0.16%) 226.62ms (± 0.25%) +0.30ms (+ 0.13%) 225.19ms 234.26ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.31ms (± 0.16%) 228.24ms (± 0.21%) -0.07ms (- 0.03%) 227.18ms 238.57ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.07ms (± 0.17%) 208.99ms (± 0.21%) -0.08ms (- 0.04%) 207.98ms 215.97ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52617 6
Baseline main 6

Developer Information:

Download Benchmark

jakebailey
jakebailey approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming back to this, I think this is good (especially given I closed my own #52551 saying this PR is the correct one).

@jakebailey jakebailey merged commit 3073b52 into microsoft:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@navya9singh navya9singh Awaiting requested review from navya9singh

Assignees

@navya9singh navya9singh

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit type conversion of tuple [...T[]] to array T[]
4 participants
@Andarist @jakebailey @typescript-bot @navya9singh